Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for generic struct deserialization when using ReadOnlySequence #352

Merged

Conversation

nathanAjacobs
Copy link

This should fix issue #351.

@neuecc
Copy link
Member

neuecc commented Feb 6, 2025

Thank you, it looks good.
It seems that we need to make some fundamental changes to the way generics and unmanaged structs are handled.

@neuecc neuecc merged commit baf6c26 into Cysharp:main Feb 6, 2025
@nathanAjacobs
Copy link
Author

Thank you for merging this in! I know you have a lot of great libraries to maintain, so I appreciate you taking the time to look at this.

@neuecc
Copy link
Member

neuecc commented Feb 7, 2025

I'd like to release it right away, but it's currently held up due to a CI error, so please wait just a bit.
I'll get it out as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants